Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Serialize and Deserialize for box types #324

Merged
merged 1 commit into from Mar 7, 2019
Merged

Derive Serialize and Deserialize for box types #324

merged 1 commit into from Mar 7, 2019
+7 −45

Conversation

@nical
Copy link
Collaborator

nical commented Mar 7, 2019 •
edited by larsbergstrom

Thankfully, serde has magic attributes to avoid requiring U: Serialize etc.

This change is Reviewable
@nical
Derive Serialize and Deserialize for box types.
Loading status checks…
0c08d2f
@nical
Copy link
Collaborator Author

nical commented Mar 7, 2019

r? @kvark
@nical
Copy link
Collaborator Author

nical commented Mar 7, 2019

Also removed the default type U = UnknownUnit in Box3D Since it was removed in Box2D.
@kvark
kvark approved these changes Mar 7, 2019
View changes
Copy link
Member

kvark left a comment

Sweet!
@kvark
Copy link
Member

kvark commented Mar 7, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

📌 Commit 0c08d2f has been approved by kvark
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

⌛ Testing commit 0c08d2f with merge 55e60b9...
bors-servo added a commit that referenced this pull request Mar 7, 2019
@bors-servo
Auto merge of #324 - nical:box-serde, r=kvark
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
55e60b9 
Derive Serialize and Deserialize for box types

Thankfully, serde has magic attributes to avoid requiring `U: Serialize` etc.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/324)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

☀️ Test successful - checks-travis
Approved by: kvark
Pushing 55e60b9 to master...
@bors-servo bors-servo merged commit 0c08d2f into servo:master Mar 7, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nical @kvark @bors-servo
You can’t perform that action at this time.