Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAccess members directly instead of using min_x(),min_y(),etc. in Box3D #325
+83
−148
Conversation
|
I like the series of improvements! |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 7, 2019
Access members directly instead of using min_x(),min_y(),etc. in Box3D I'm not sure what we'll do about #321 but in the mean time, directly accessing the members in the box types makes it clear that no code will implicitly paper over negative rects. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/325) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2019
Access members directly instead of using min_x(),min_y(),etc. in Box3D I'm not sure what we'll do about #321 but in the mean time, directly accessing the members in the box types makes it clear that no code will implicitly paper over negative rects. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/325) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedMar 7, 2019
•
edited by larsbergstrom
I'm not sure what we'll do about #321 but in the mean time, directly accessing the members in the box types makes it clear that no code will implicitly paper over negative rects.
This change is