Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove serialization of rects and side offsets #327
Merged
Conversation
kvark
changed the title
|
Had to avoid touching the sized offsets because they use the proc macro magic for derives... |
|
|
kvark
changed the title
|
@nical rebased now, PTAL |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 2, 2019
Improve serialization of rects and side offsets Note: breaking change <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/327) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 3, 2019
Automatically derive serde traits for more types Similar to #327, adding rotations, translations and scales to the list of types deriving their serde implementations automatically. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/355) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedMar 14, 2019
•
edited by larsbergstrom
Note: breaking change
This change is