Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSimplify rigid transform premultiplication math #337
Merged
Conversation
src/rigid.rs
Outdated
| // R1 * R2 = R' | ||
| // (R'^-1 * T' * R') = T'' = T' rotated by R' | ||
| // T'' * T2 = T''' = vector addition of translations T2 and T'' | ||
| // T' * T2 = T' = vector addition of translations T2 and T' |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 25, 2019
Simplify rigid transform premultiplication math Doesn't need to be so complicated, I'd done the math in a slightly inefficient way <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/337) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedApr 24, 2019
•
edited by larsbergstrom
Doesn't need to be so complicated, I'd done the math in a slightly inefficient way
This change is