Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make intersects check for empty rects #340

Closed
wants to merge 1 commit into from
Closed

make intersects check for empty rects #340

wants to merge 1 commit into from
+10 −2

Conversation

@aosmond
Copy link

aosmond commented May 10, 2019 •
edited by larsbergstrom

This change is Reviewable
@aosmond
Copy link
Author

aosmond commented May 10, 2019

try (linux reftests): https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb597c0b10f52b94ff010f6a6aeb761edf78cfba
try (wrench): https://treeherder.mozilla.org/#/jobs?repo=try&revision=134abebee9eea6988692920941ddee8ea73357f2
@aosmond aosmond force-pushed the aosmond:ao_fix_intersects_empty branch from 339e0aa to 95229fd May 10, 2019
@aosmond
make intersects check for empty rects
Loading status checks…
8526396
@aosmond aosmond force-pushed the aosmond:ao_fix_intersects_empty branch from 95229fd to 8526396 May 10, 2019
@nical
Copy link
Collaborator

nical commented May 10, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

📌 Commit 8526396 has been approved by nical
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Testing commit 8526396 with merge eb191fd...
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #340 - aosmond:ao_fix_intersects_empty, r=nical
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eb191fd 
make intersects check for empty rects

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/340)
<!-- Reviewable:end -->
@kvark
Copy link
Member

kvark commented May 10, 2019

@nical hold on a bit plz
bors r-
@kvark
Copy link
Member

kvark commented May 10, 2019

@bors-servo r-
@aosmond aosmond closed this May 10, 2019
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2019

💥 Test timed out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@aosmond @nical @bors-servo @kvark
You can’t perform that action at this time.