Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Default trait for Rect and SideOffsets #343
Merged
+18
−0
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 10, 2019
Implement Default trait for Rect and SideOffsets I'm working on WR display list serialization changes and @gankro asked me implement `Default` trait for WR `DisplayItem`s. I noticed that of the types that WR uses, implementations of `Default` are missing for these two. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/343) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
djg commentedJun 10, 2019
•
edited by larsbergstrom
I'm working on WR display list serialization changes and @gankro asked me implement
Defaulttrait for WRDisplayItems. I noticed that of the types that WR uses, implementations ofDefaultare missing for these two.This change is