Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove euclid_macros #346

Merged
merged 1 commit into from Jun 21, 2019
Merged

Remove euclid_macros #346

merged 1 commit into from Jun 21, 2019

Conversation

@nical
Copy link
Collaborator

nical commented Jun 19, 2019

This makes euclid much faster to build with default features.


This change is Reviewable

@nical
Copy link
Collaborator Author

nical commented Jun 19, 2019

r? @kvark

@nical nical force-pushed the nical:rm-euclid-macros branch from f7744d6 to 67e36b8 Jun 19, 2019
@jdm
Copy link
Member

jdm commented Jun 19, 2019

Travis is unhappy.

@nical nical force-pushed the nical:rm-euclid-macros branch from 67e36b8 to 66745bd Jun 19, 2019
This makes euclid much faster to build with default features.
@nical nical force-pushed the nical:rm-euclid-macros branch from 66745bd to d0a3d71 Jun 20, 2019
@kvark
kvark approved these changes Jun 21, 2019
Copy link
Member

kvark left a comment

m11, m12,
m21, m22,
m31, m32,
) = try!(serde::Deserialize::deserialize(deserializer));

This comment has been minimized.

@kvark

kvark Jun 21, 2019

Member

oh wow, try!

@kvark
Copy link
Member

kvark commented Jun 21, 2019

Too spoiled by the real bors, who understands Approval...
@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2019

📌 Commit d0a3d71 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2019

Testing commit d0a3d71 with merge ff53a6c...

bors-servo added a commit that referenced this pull request Jun 21, 2019
Remove euclid_macros

This makes euclid much faster to build with default features.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 21, 2019

☀️ Test successful - checks-travis
Approved by: kvark
Pushing ff53a6c to master...

@bors-servo bors-servo merged commit d0a3d71 into servo:master Jun 21, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.