Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upNudge rustc to inline a few things more aggressively #347
Conversation
|
r? @kvark |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 24, 2019
Nudge rustc to inline a few things more aggressively Rustc seems to be a bit shy about cross-crate inlining. It looks like even with thin lto inlined functions inside of inlined functions don't necessarily get inlined even for trivial things like `to_vector()` calling `vec2()` calling `TypedVector2D::new`. This patch removes a bunch of instructions in a piece of code I was profiling earlier. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/347) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedJun 21, 2019
•
edited by larsbergstrom
Rustc seems to be a bit shy about cross-crate inlining. It looks like even with thin lto inlined functions inside of inlined functions don't necessarily get inlined even for trivial things like
to_vector()callingvec2()callingTypedVector2D::new.This patch removes a bunch of instructions in a piece of code I was profiling earlier.
This change is