Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upA few non-breaking changes #349
Conversation
|
r? @kvark Note that I put |
| @@ -220,7 +220,6 @@ where | |||
| { | |||
| /// Inflates the box by the specified sizes on each side respectively. | |||
| #[inline] | |||
| #[cfg_attr(feature = "unstable", must_use)] | |||
This comment has been minimized.
This comment has been minimized.
emilio
Jun 25, 2019
Member
Servo benefits from these annotations don't they? Plus must_use is stable now, so maybe we should just remove the cfg_attr.
This comment has been minimized.
This comment has been minimized.
nical
Jun 25, 2019
Author
Collaborator
Ah nice! I hadn't realized it was stable in function annotations now. I don't know whether servo uses the unstable feature.
I'll remove the cfg_attr.
src/lib.rs, line 143 at r1 (raw file):
if we end up with just |
|
src/lib.rs, line 143 at r1 (raw file): Previously, kvark (Dzmitry Malyshau) wrote…
These default type parameters have never ended up being useful. I'm not even sure in what situations the compiler decides to make usre of that information. |
|
@bors-servo r=kvark |
|
|
A few non-breaking changes - Add pre/post_transform, deprecate pre/post_mul. This name is less ambiguous: the meaning of pre and post here is really about the semantics of the tranformation and not about the underlying matrix the latter being currently in a confusing step for a number of people. - Add a `default` module with type aliases for the default unit. The goal is to rename all `TypedFoo` types into `Foo` next time we commit to a breaking change and use `default::Foo` for the aliases with unknown units. - Remove unstable must_use annotations. They add noise to the code and aren't very useful since they only work with the nightly compiler and the unstable feature. The first two changes will let us transition some of the names at our leasure rather than having to do it all next time we do the Big Breaking Change. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/349) <!-- Reviewable:end -->
|
|
nical commentedJun 25, 2019
•
edited
defaultmodule with type aliases for the default unit. The goal is to rename allTypedFootypes intoFoonext time we commit to a breaking change and usedefault::Foofor the aliases with unknown units.The first two changes will let us transition some of the names at our leasure rather than having to do it all next time we do the Big Breaking Change.
This change is