Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRename TypedFoo types into Foo #351
Merged
Conversation
|
Assuming this is a simple search&replace change, didn't read all of it |
|
@bors-servo r=kvark |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 2, 2019
Rename TypedFoo types into Foo Number two in a [long list](https://github.com/nical/euclid/commits/breaking-changes) of breaking changes. This removes the "Typed" prefix on most types (for example TypedRect) which is now unnecessary since the default version of these types using `UnknownUnit` are now in the `euclid::default` namespace. For users of euclid, accustomed to manipulating the default types, this means that they don't need to look up the doc for `TypedRect` when they think about `Rect`. This doesn't seem like much but since nobody uses `TypedFoo` types directly other than to create aliases in a single place, the names in the documentation never match the names users actually manipulate and the `Typed` prefix is easily forgotten. As a result the names are a bit prettier and the docs more intuitive. r? anyone <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/351) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedJun 29, 2019
•
edited by larsbergstrom
Number two in a long list of breaking changes.
This removes the "Typed" prefix on most types (for example TypedRect) which is now unnecessary since the default version of these types using
UnknownUnitare now in theeuclid::defaultnamespace.For users of euclid, accustomed to manipulating the default types, this means that they don't need to look up the doc for
TypedRectwhen they think aboutRect. This doesn't seem like much but since nobody usesTypedFootypes directly other than to create aliases in a single place, the names in the documentation never match the names users actually manipulate and theTypedprefix is easily forgotten.As a result the names are a bit prettier and the docs more intuitive.
r? anyone
This change is