Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove a few methods #352
Merged
Remove a few methods #352
+30
−243
Conversation
|
r? @kvark |
src/size.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl<T: Copy, U> Into<Vector2D<T, U>> for Size2D<T, U> { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 3, 2019
Remove a few methods Number three in a [long list](https://github.com/nical/euclid/commits/breaking-changes) of breaking changes. - Remove deprecated transform pre_mul/post_mul methods. We already have pre_transform/post_transform which are less ambiguous. It is possible that we will reintroduce pre_mul/post_mul later but if so their name will follow the matrix multiplication convention rather than the semantic of the transformation so they may or may not become the opposite of what they are now depending on the chosen matrix convention. So it's best to remove them for at least a release and add them back when the dependent crates have moved to pre_transform/post_transform to avoid bugs. - Remove `*_typed` methods. They are too much of a mouthful and nobody uses them as far as I know. It'd be nice to come up with a nicer naming scheme to reintroduce methods returning `Length<T, U>` in addition to the ones that return `T`, we can do that without causing breaking changes whenever we settle for something. - Remove `Rect::translate_by_size` and make it easier to convert sizes into vectors instead to achieve the same thing. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/352) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedJul 2, 2019
•
edited
Number three in a long list of breaking changes.
*_typedmethods. They are too much of a mouthful and nobody uses them as far as I know. It'd be nice to come up with a nicer naming scheme to reintroduce methods returningLength<T, U>in addition to the ones that returnT, we can do that without causing breaking changes whenever we settle for something.Rect::translate_by_sizeand make it easier to convert sizes into vectors instead to achieve the same thing.This change is