Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSome Rect changes #357
Merged
Some Rect changes #357
+304
−6
Conversation
|
r? @jrmuizel |
src/nonempty.rs
Outdated
| }) | ||
| } | ||
|
|
||
| /// Returns true if this box contains the interior of the other box. Always |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nical
Jul 3, 2019
Author
Collaborator
A copy-paste accident from the equivalent comment in the non-non-empty type. Fixed.
src/nonempty.rs
Outdated
| pub fn union(&self, other: &NonEmpty<Box3D<T, U>>) -> NonEmpty<Box3D<T, U>> { | ||
| NonEmpty(Box3D { | ||
| min: point3( | ||
| max(self.min.x, other.min.x), |
This comment has been minimized.
This comment has been minimized.
kvark
Jul 3, 2019
Member
this is computing the intersection, not union... do we have any test coverage for this?
This comment has been minimized.
This comment has been minimized.
| use core::cmp::{PartialEq}; | ||
|
|
||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| #[derive(Copy, Clone, Debug, PartialEq, Eq, Hash)] |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nical
force-pushed the
nical:breaking-7
branch
2 times, most recently
from
c4f55d9
to
0e4deb4
|
@bors-servo r=kvark |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 4, 2019
Some Rect changes - Introduce `NonEmpty<T>` as discussed in #339. - Remove the default unit parameter in Rect as the compiler rarely seem to make use of that information. - Treat negative rects as empty rects in contains_rect (just like we do in Box2D and Box3D). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/357) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedJul 3, 2019
•
edited by larsbergstrom
NonEmpty<T>as discussed in #339.This change is