Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass points vectors and sizes by value #358

Merged
merged 3 commits into from Jul 3, 2019
Merged

Pass points vectors and sizes by value #358

merged 3 commits into from Jul 3, 2019

Conversation

@nical
Copy link
Collaborator

nical commented Jul 3, 2019 •
edited

Fixes #269. The general rule is, points, vectors, sizes and smaller things are passed by value, other types (larger ones) by reference. It's arbitrary but at least it's consistent.

Also renamed Rotation3D's rotate_* methods into transform_* since all other transform types use the latter name.

This change is Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

☔ The latest upstream changes (presumably #352) made this pull request unmergeable. Please resolve the merge conflicts.
@kvark
kvark approved these changes Jul 3, 2019
View changes
nical added 2 commits Jun 26, 2019
@nical
Pass vector, points and sizes by value more consistently.
ecd0685
@nical
Pass points, vectors and sizes by value in transforms.
b8a5d97
@nical nical force-pushed the nical:breaking-8 branch from a12d006 to 6af4fb1 Jul 3, 2019
@nical
Rename Rotation3D::rotate_point/vector into transform_point/vector fo…
Loading status checks…
9a1a548 
…r consistency.
@nical nical force-pushed the nical:breaking-8 branch from 6af4fb1 to 9a1a548 Jul 3, 2019
@nical
Copy link
Collaborator Author

nical commented Jul 3, 2019

@bors-servo r=kvark
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

📌 Commit 9a1a548 has been approved by kvark
bors-servo added a commit that referenced this pull request Jul 3, 2019
@bors-servo
Auto merge of #358 - nical:breaking-8, r=kvark
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d57a4f4 
Pass points vectors and sizes by value

Fixes #269. The general rule is, points, vectors, sizes and smaller things are passed by value, other types (larger ones) by reference. It's arbitrary but at least it's consistent.

Also renamed `Rotation3D`'s `rotate_*` methods into `transform_*` since all other transform types use the latter name.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/358)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

⌛ Testing commit 9a1a548 with merge d57a4f4...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 3, 2019

☀️ Test successful - checks-travis
Approved by: kvark
Pushing d57a4f4 to master...
@bors-servo bors-servo merged commit 9a1a548 into servo:master Jul 3, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Figure out a good rule of thumb about what should be passed by value/ref.
3 participants
@nical @bors-servo @kvark
You can’t perform that action at this time.