Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow building non-`Trig` transforms that don't rotate #367
Conversation
The `Trig` trait bound is only required for doing rotations, and also `Trig` is only implemented for `f64` and `f32`. Putting the `Trig` trait bound on the main `impl` for `Transform2D` methods was a pretty restrictive and applied restrictions more often than was needed. This commit moves the `Trig` trait bound to an `impl` specifically for rotation-related methods of `Transform2D`, and the result is that we can now scale or translate things represented with `i32` or `i64` or other non-`Trig` scalars.
|
Neat. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 11, 2019
…orm-2d-methods, r=nical Allow building non-`Trig` transforms that don't rotate The `Trig` trait bound is only required for doing rotations, and also `Trig` is only implemented for `f64` and `f32`. Putting the `Trig` trait bound on the main `impl` for `Transform2D` methods was a pretty restrictive and applied restrictions more often than was needed. This commit moves the `Trig` trait bound to an `impl` specifically for rotation-related methods of `Transform2D`, and the result is that we can now scale or translate things represented with `i32` or `i64` or other non-`Trig` scalars. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/367) <!-- Reviewable:end -->
|
|
fitzgen
deleted the
fitzgen:less-restrictive-trait-bounds-for-transform-2d-methods
branch
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fitzgen commentedAug 10, 2019
•
edited by larsbergstrom
The
Trigtrait bound is only required for doing rotations, and alsoTrigis only implemented forf64andf32. Putting theTrigtrait bound on the mainimplforTransform2Dmethods was a pretty restrictive and applied restrictions more often than was needed.This commit moves the
Trigtrait bound to animplspecifically for rotation-related methods ofTransform2D, and the result is that we can now scale or translate things represented withi32ori64or other non-Trigscalars.This change is