Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc about default aliases. #371

Merged
merged 1 commit into from Oct 4, 2019
Merged

Fix doc about default aliases. #371

merged 1 commit into from Oct 4, 2019

Conversation

@nical
Copy link
Collaborator

nical commented Oct 4, 2019 •
edited by larsbergstrom

Fixes #370.

This change is Reviewable
@nical
Fix doc about default aliases.
Loading status checks…
621bc25
@kvark
kvark approved these changes Oct 4, 2019
View changes
@nical
Copy link
Collaborator Author

nical commented Oct 4, 2019

@bors-servo r=kvark
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2019

📌 Commit 621bc25 has been approved by kvark
bors-servo added a commit that referenced this pull request Oct 4, 2019
@bors-servo
Auto merge of #371 - nical:doc-fix, r=kvark
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
90727bd 
Fix doc about default aliases.

Fixes #370.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/371)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2019

⌛ Testing commit 621bc25 with merge 90727bd...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2019

💔 Test failed - checks-travis
@nical
Copy link
Collaborator Author

nical commented Oct 4, 2019

@bors-servo r=kvark
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2019

📌 Commit 621bc25 has been approved by kvark
bors-servo added a commit that referenced this pull request Oct 4, 2019
@bors-servo
Auto merge of #371 - nical:doc-fix, r=kvark
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a79bec6 
Fix doc about default aliases.

Fixes #370.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/371)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2019

⌛ Testing commit 621bc25 with merge a79bec6...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2019

☀️ Test successful - checks-travis
Approved by: kvark
Pushing a79bec6 to master...
@bors-servo bors-servo merged commit 621bc25 into servo:master Oct 4, 2019
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Failed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Documentation incorrect after removing Typed*
3 participants
@nical @bors-servo @kvark
You can’t perform that action at this time.