Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd `cast_unit` to the rest of the basic geometric types #376
+46
−1
Conversation
|
Looks good to me, Thanks! Could you add a commit that bumps the version to 0.20.4 in Cargo.toml ? |
Done. |
|
Thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 16, 2019
Add `cast_unit` to the rest of the basic geometric types This is much more convenient than `X::from_untyped(x.to_untyped())`, and previously only existed on `Vector2D`. The implementation on `Vector2D` is marked `#[inline]` but it doesn't seem like it needs to be since it is generic in the unit? Not sure if that has any effect there? I left the others without `#[inline]` but I can change it if you'd like.
|
|
|
Up on crates.io https://crates.io/crates/euclid/0.20.4 |
|
Thanks so much for doing that so fast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kyren commentedNov 16, 2019
This is much more convenient than
X::from_untyped(x.to_untyped()), and previously only existed onVector2D.The implementation on
Vector2Dis marked#[inline]but it doesn't seem like it needs to be since it is generic in the unit? Not sure if that has any effect there? I left the others without#[inline]but I can change it if you'd like.