Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix pre_scale on transform2d and transform3d #377
Merged
Conversation
|
Oops! Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 25, 2019
Fix pre_scale on transform2d and transform3d Fix the `pre_scale` method on both `Transform2D` and `Transform3D` plus added a test to make sure `pre_scale` and `post_scale` matched the equivalent sequence using full transforms.
|
|
Merged
bors-servo
added a commit
that referenced
this pull request
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nickwilcox commentedNov 23, 2019
Fix the
pre_scalemethod on bothTransform2DandTransform3Dplus added a test to make surepre_scaleandpost_scalematched the equivalent sequence using full transforms.