Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upangle: split angle.rs from rotation.rs #381
Merged
Conversation
|
I don't feel strongly either way. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 25, 2019
angle: split angle.rs from rotation.rs Feel free to throw this away, but I was reading through Euclid's code and I would have found it more clear to have Angle in its own module, as we do for Rect etc. (I want to compare it with https://gitlab.gnome.org/GNOME/librsvg/blob/master/rsvg_internals/src/angle.rs )
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pbor commentedNov 25, 2019
Feel free to throw this away, but I was reading through Euclid's code and I would have found it more clear to have Angle in its own module, as we do for Rect etc.
(I want to compare it with https://gitlab.gnome.org/GNOME/librsvg/blob/master/rsvg_internals/src/angle.rs )