Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some methods of Rect to not require unused trait 'Zero' #395

Merged
merged 1 commit into from Jan 20, 2020
Merged

Change some methods of Rect to not require unused trait 'Zero' #395

merged 1 commit into from Jan 20, 2020

Conversation

@Cobrand
Copy link
Contributor

Cobrand commented Jan 20, 2020 •
edited

Some methods of Rect required an unused 'Zero' trait, this PR removes the 'Zero' requirement from the methods which don't need this trait.

This is mostly useful for external numerical types which don't implement anything from num-traits (and thus don't implement Zero)

This change is Reviewable
@Cobrand
Change some methods of Rect to not require unused trait 'Zero'
Loading status checks…
f73541d
@nical
Copy link
Collaborator

nical commented Jan 20, 2020

Thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 20, 2020

📌 Commit f73541d has been approved by nical
bors-servo added a commit that referenced this pull request Jan 20, 2020
@bors-servo
Auto merge of #395 - Cobrand:master, r=nical
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3c23891 
Change some methods of Rect to not require unused trait 'Zero'

Some methods of Rect required an unused 'Zero' trait, this PR removes the 'Zero' requirement from the methods which don't need this trait.

This is mostly useful for external numerical types which don't implement anything from num-traits (and thus don't implement `Zero`)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/395)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 20, 2020

⌛ Testing commit f73541d with merge 3c23891...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 20, 2020

☀️ Test successful - checks-travis
Approved by: nical
Pushing 3c23891 to master...
@bors-servo bors-servo merged commit f73541d into servo:master Jan 20, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Cobrand @nical @bors-servo
You can’t perform that action at this time.