Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Rect::contains #40
Merged
Conversation
For some reason, I managed to convince myself and others that Rect::contains should be inclusive of both edges, but that's clearly wrong, as then a Rect with size (1, 1) has an area of 4.
mbrubeck
added a commit
that referenced
this pull request
Jul 7, 2014
Fix Rect::contains. r=mbrubeck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zwarich commentedJul 4, 2014
For some reason, I managed to convince myself and others that
Rect::contains should be inclusive of both edges, but that's clearly
wrong, as then a Rect with size (1, 1) has an area of 4.