Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Default and Hash for Length, add Length to defaults #402

Merged
merged 3 commits into from Mar 9, 2020
Merged

Implement Default and Hash for Length, add Length to defaults #402

merged 3 commits into from Mar 9, 2020

Conversation

@Mingun
Copy link
Contributor

Mingun commented Mar 8, 2020

Fix #401
Mingun added 3 commits Mar 8, 2020
@Mingun
Implement Default for Length
3df60be
@Mingun
Implement Hash for Length
c8ae912
@Mingun
Add Length to defaults
Loading status checks…
7163cab
@nical
Copy link
Collaborator

nical commented Mar 9, 2020

Thanks! @bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2020

📌 Commit 7163cab has been approved by nical
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2020

⌛ Testing commit 7163cab with merge 7c041a8...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2020

☀️ Test successful - checks-travis
Approved by: nical
Pushing 7c041a8 to master...
@bors-servo bors-servo merged commit 7c041a8 into servo:master Mar 9, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@Mingun Mingun deleted the Mingun:length branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Length does not implement Default and have no defaults equivalent
3 participants
@Mingun @nical @bors-servo
You can’t perform that action at this time.