Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some documentation nitpits #403

Merged
merged 6 commits into from Mar 11, 2020
Merged

Fix some documentation nitpits #403

merged 6 commits into from Mar 11, 2020
+163 −15

Conversation

@Mingun
Copy link
Contributor

Mingun commented Mar 8, 2020

No description provided.

@nical
nical reviewed Mar 9, 2020
View changes
Copy link
Collaborator

nical left a comment

Looks good overall, thanks! Please remove the commit about exclusive range notation and this is good to go.
src/angle.rs Outdated Show resolved Hide resolved
Mingun added 6 commits Mar 8, 2020
@Mingun
Fix documentation for approxord
7550bc0
@Mingun
Add some simple documentation to constructor functions
ad49352
@Mingun
Add and fix some documentation
df15560
@Mingun
Fully document size.rs
ae62d85
@Mingun
Document Round/Ceil/Floor traits
150c2c3
@Mingun
Document vector.rs
Loading status checks…
9e979c1
@Mingun Mingun force-pushed the Mingun:doc branch from d573bfe to 9e979c1 Mar 9, 2020
@Mingun
Copy link
Contributor Author

Mingun commented Mar 9, 2020

Done
@nical
Copy link
Collaborator

nical commented Mar 11, 2020

Thanks! @bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2020

📌 Commit 9e979c1 has been approved by nical
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2020

⌛ Testing commit 9e979c1 with merge fe40f69...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 11, 2020

☀️ Test successful - checks-travis
Approved by: nical
Pushing fe40f69 to master...
@bors-servo bors-servo merged commit fe40f69 into servo:master Mar 11, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 11, 2020
Merged
@Mingun Mingun deleted the Mingun:doc branch Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Mingun @nical @bors-servo
You can’t perform that action at this time.