Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSome refactoring for size.rs #412
Merged
+978
−398
Conversation
|
|
This reuses the code and improves readability
…eatify looking documentation
… impl block Since the traits implementation documentation goes after impl blocks, move all impl blocks together
This creates more beatify looking documentation
This creates more beatify looking documentation and improves code navigation
This creates more beatify looking documentation and improves code navigation
Thus, it is easier to understand from the code which operators are implemented
This allow to filter what tests to run with standard cargo commands
…r Size3D
… Copy bounds in try_cast/cast methods
|
Looks good, thanks! @bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Mingun commentedMar 15, 2020
Part of large changeset, which includes also #410 and #411. Aimed to improve ergonomics, fill gaps in the API and overall consistency.