Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation: add missing documentation, simplify type bounds #425

Merged
merged 3 commits into from Apr 6, 2020

Conversation

@Mingun
Copy link
Contributor

Mingun commented Apr 4, 2020

No description provided.

Copy link
Collaborator

nical left a comment

Looks good, just one thing to change in the doc.

src/rotation.rs Outdated Show resolved Hide resolved
@Mingun Mingun force-pushed the Mingun:rotation branch from 0ae823e to d7a08d7 Apr 6, 2020
@Mingun
Copy link
Contributor Author

Mingun commented Apr 6, 2020

Done

@nical
Copy link
Collaborator

nical commented Apr 6, 2020

Thanks. @bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

📌 Commit d7a08d7 has been approved by nical

@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

Testing commit d7a08d7 with merge 7f2f303...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

☀️ Test successful - checks-travis
Approved by: nical
Pushing 7f2f303 to master...

@bors-servo bors-servo merged commit 7f2f303 into servo:master Apr 6, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@Mingun Mingun deleted the Mingun:rotation branch Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.