Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to Rust 2018; some cleanups #426
Merged
Conversation
This is a fully automatic change, running `cargo fix --edition`. I've done a quick review and everything looks fine to me.
I believe this is the idiomatic way to do it with the 2018 edition. I think it's worth the slight increase in verbosity, as it's much more clear where the derive macros come from.
|
CI fails for Rust 1.31.0. I'm looking into it. |
Doc tests failed to compile because of this on Rust 1.31.0 (on probably other older versions too). The compiler complained about `core` being defined multiple times. I don't quite understand what was going on there, but the re-export wasn't necessary and this seems cleaner anyway.
I'm sure it served a purpose at some point, but as far as I can tell, everything seems to work without it now.
|
Pushed two additional clean-up commits, the first of which fixes the CI build. |
|
Looks good, thanks! @bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
hannobraun commentedApr 10, 2020
No description provided.