Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax trait bounds for Transforms #427

Merged
merged 11 commits into from Apr 11, 2020
Merged

Relax trait bounds for Transforms #427

merged 11 commits into from Apr 11, 2020

Conversation

@Mingun
Copy link
Contributor

Mingun commented Apr 11, 2020

Also some minor documentation about matrices that create by various methods
Mingun added 11 commits Mar 22, 2020
@Mingun
Transform: relax bounds for some unit conversion methods
8a6dea5
@Mingun
Transform: relax bounds for Transform3D::row_major_2d() and Transform…
473bd5d 
…2D::to_3d()
@Mingun
Transform: relax bounds for 2D transform related functions
9d79780
@Mingun
Transform: move Copy impl block just after main impl block
e263a69
@Mingun
Transform: relax bounds for create_perspective() and create_skew()
f7f8e8f
@Mingun
Transform: relax bounds for approx_eq() and approx_eq_eps()
d109d36
@Mingun
Transform: relax bounds for create transformations and apply transfor…
d3c7b6a 
…mations methods
@Mingun
Transform: reorder and group impl blocks with creating and applying t…
88cd037 
…ransformations methods
@Mingun
Transform: relax bounds for identity() methods
678827f
@Mingun
Transform: relax bounds for transformation creations methods
4e7f13e 
Relax requirements on all dependent methods
@Mingun
Transform: relax bounds for transform methods
Loading status checks…
40a1fb1
@nical
Copy link
Collaborator

nical commented Apr 11, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2020

📌 Commit 40a1fb1 has been approved by nical
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2020

⌛ Testing commit 40a1fb1 with merge 8f9f1b5...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2020

☀️ Test successful - checks-travis
Approved by: nical
Pushing 8f9f1b5 to master...
@bors-servo bors-servo merged commit 8f9f1b5 into servo:master Apr 11, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 11, 2020
Merged
@Mingun Mingun deleted the Mingun:transform branch Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Mingun @nical @bors-servo
You can’t perform that action at this time.