Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement `distance_to` method for points #428
Merged
Conversation
I don't know, if such a simple helper method is considered acceptable for this crate, but I figured the best way of asking that question is by just submitting a pull request. I'm also not sure about the return value. It seems like returning `Length` would be the right thing to do, but that's not what the `length` methods return. I figured I'd follow that established convention, but I'm happy to make changes as requested.
|
Looks good to me, thanks.
We'll probably add back @bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
hannobraun commentedApr 11, 2020
I don't know, if such a simple helper method is considered acceptable
for this crate, but I figured the best way of asking that question is by
just submitting a pull request.
I'm also not sure about the return value. It seems like returning
Lengthwould be the right thing to do, but that's not what thelengthmethods return. I figured I'd follow that establishedconvention, but I'm happy to make changes as requested.