Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactoring and cleanup for bounding boxes #430

Merged
merged 10 commits into from Apr 21, 2020
Merged

Some refactoring and cleanup for bounding boxes #430

merged 10 commits into from Apr 21, 2020
+471 −446

Conversation

@Mingun
Copy link
Contributor

Mingun commented Apr 17, 2020

Includes Rect, Box2D, Box3D:

  • Relax boundaries
  • Implement Assignment Mul/Div operators
  • Reuse some implementations where possible
Mingun added 10 commits Apr 14, 2020
@Mingun
Box2D: add comment from #177 to documentation
b383147
@Mingun
BBs: merge NumCast + Copy impl blocks like in other files
61f23ec
@Mingun
BBs: remove unnecessary type bounds
16cdc03
@Mingun
Rect: remove yet more unnecessary bounds
cd3dbb0
@Mingun
Rect: reuse some Box2D routines in Rect implementation
e8895bd 
That routines already used, but was inlined manually
@Mingun
BBs: reuse some methods in NonEmpty implementation
e808133
@Mingun
BBs: merge impl blocks with identical bounds
302ed37
@Mingun
BBs: do not restrict operators only to the same type, as wrapped
b51042e
@Mingun
BBs: implement *Assign counterparts for operators
1d67271
@Mingun
BBs: use Clone bounds for operators for symmetry with other structs: …
Loading status checks…
e3cca9e 
…Points and Vectors
@nical
Copy link
Collaborator

nical commented Apr 21, 2020

Reusing the box code in Rect and NonEmpty is a nice simplification, thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2020

📌 Commit e3cca9e has been approved by nical
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2020

⌛ Testing commit e3cca9e with merge 3bba2f1...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2020

☀️ Test successful - checks-travis
Approved by: nical
Pushing 3bba2f1 to master...
@bors-servo bors-servo merged commit 3bba2f1 into servo:master Apr 21, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@Mingun Mingun deleted the Mingun:box branch Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Mingun @nical @bors-servo
You can’t perform that action at this time.