Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd `Vector2D::try_normalize` and `Vector3D::try_normalize`. #431
Conversation
These methods check that the length of the vector is not zero and return None in that case. It is slightly cleaner than either checking that the vector is not *equal* to zero or checking that the length is not zero before calling the regular `normalize` method. If the vector has very small component values, length may be calculated as zero, and thus the length of the normalized vector will be infinity.
|
Looks good to me, thanks! @bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kyren commentedApr 25, 2020
These methods check that the length of the vector is not zero and return None in
that case. It is slightly cleaner than either checking that the vector is
not equal to zero or checking that the length is not zero before calling the
regular
normalizemethod.If the vector has very small component values, length may be calculated as zero,
and thus the length of the normalized vector will be infinity.
Another possibility here is to copy
nalgebraand have amin_lengthparameter, rather than assuming that minimum length is always zero.