Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the documentation of Transform3D::perspective #466

Merged
merged 2 commits into from Aug 21, 2020

Conversation

@nical
Copy link
Collaborator

nical commented Aug 21, 2020

There was a bit of confusion about the formulation of the perspective transform in #465. This clarifies things.

@nical nical requested a review from kvark Aug 21, 2020
@kvark
kvark approved these changes Aug 21, 2020
Copy link
Member

kvark left a comment

And you want to publish this for one comment?

@nical
Copy link
Collaborator Author

nical commented Aug 21, 2020

Yep, that and #464 which was contributed but not published yet. It's effortless to publish this kind of small non-breaking changes, we don't even have to update gecko.

@bors-servo r=kvark

@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2020

📌 Commit a8dfc57 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2020

Testing commit a8dfc57 with merge 4264949...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2020

☀️ Test successful - checks-travis
Approved by: kvark
Pushing 4264949 to master...

@bors-servo bors-servo merged commit 4264949 into servo:master Aug 21, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@nical nical deleted the nical:perspective-doc branch Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.