Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix doc test failures after ScaleFactor changes #53
+3
−1
Conversation
ScaleFactor now needs a number type annotation in addition to the units. Incidentally needed to include use statements.
mbrubeck
added a commit
that referenced
this pull request
Nov 5, 2014
Fix doc test failures after ScaleFactor changes. r=mbrubeck
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
brookst commentedNov 5, 2014
This package failed it's doc tests for me using:
ScaleFactor now needs a number type annotation in addition to the units.
Incidentally needed to include use statements.
I'm just looking into Rust, so hopefully these changes are correct but comment if not.