Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix errors after numerics reform #54
Closed
+13
−12
Conversation
|
I think we should just change callers of Zero and One to use things like Length(0.0). Are there any cases where they need to be generic? |
|
@mbrubeck The matrix identity function uses those, for example. |
|
What about introducing a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruuda commentedNov 19, 2014
There are still lots of warnings about
ZeroandOnebeing deprecated, but I do not see an easy way of resolving those without splitting everything in aFloatand anIntcase.