Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors after numerics reform #54

Closed
wants to merge 1 commit into from
Closed

Fix errors after numerics reform #54

wants to merge 1 commit into from

Conversation

@ruuda
Copy link
Contributor

ruuda commented Nov 19, 2014

There are still lots of warnings about Zero and One being deprecated, but I do not see an easy way of resolving those without splitting everything in a Float and an Int case.

@ruuda ruuda force-pushed the ruuda:numfixes branch from 0354791 to 8710b35 Nov 19, 2014
@mbrubeck
Copy link
Contributor

mbrubeck commented Nov 19, 2014

I think we should just change callers of Zero and One to use things like Length(0.0). Are there any cases where they need to be generic?

@pcwalton
Copy link
Contributor

pcwalton commented Nov 19, 2014

@mbrubeck The matrix identity function uses those, for example.

@ruuda
Copy link
Contributor Author

ruuda commented Nov 23, 2014

What about introducing a Ring trait that is Add and Mul and has one() and zero()?

@ruuda ruuda closed this May 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.