Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement `Point2D + Size2D -> Point2D`, now that we have multi-dispatch #56
Conversation
... in addition to the existing `Point2D + Point2D -> Point2D`.
mbrubeck
added a commit
that referenced
this pull request
Nov 25, 2014
Implement `Point2D + Size2D -> Point2D`, now that we have multi-dispatch
|
What does "now that we have multi-dispatch" mean? How does this work without breaking like it used to? |
|
Previously it was broken by rust-lang/rust#7590 which was recently fixed by rust-lang/rust#17669. |
|
Does this obviate the need for the double-dispatch trick employed in nalgebra? cc. @sebcrozet |
|
Yes, I believe so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedNov 21, 2014
... in addition to the existing
Point2D + Point2D -> Point2D.