Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a method to transform a point and a rect via an affine transformation #58
+25
−3
Conversation
…tion
| } | ||
|
|
||
| #[inline] | ||
| pub fn transform_rect(&self, rect: &Rect<T>) -> Rect<T> { |
This comment has been minimized.
This comment has been minimized.
SimonSapin
Nov 28, 2014
Member
What is the expected result for matrices with non-zero skews or rotation that are not multiples of 90°?
|
@SimonSapin Good point, this is totally broken. I have restructured my opacity PR in Servo to avoid using this function. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedNov 28, 2014
r? @metajack (or whoever)