Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old impl check, fix warnings #67

Merged
merged 2 commits into from Jan 31, 2015
Merged

Remove old impl check, fix warnings #67

merged 2 commits into from Jan 31, 2015

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jan 31, 2015

Also brings us to rustc 1.0.0-nightly (458a6a2f6 2015-01-25 21:20:37 +0000)

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 31, 2015

Not sure we should land this before rustupping Servo that far.

@Manishearth Manishearth force-pushed the warn-fix branch from 9203390 to 18337b8 Jan 31, 2015
src/rect.rs Outdated
#[inline]
pub fn scale(&self, x: Scale, y: Scale) -> Rect<T> {
pub fn scale<Scale: Copy>(&self, x: Scale, y: Scale) -> Rect<T> where T: Copy + Clone + Mul<Scale, Output=T>{

This comment has been minimized.

@Ms2ger

Ms2ger Jan 31, 2015

Contributor

Missing space before the {

@Manishearth Manishearth force-pushed the warn-fix branch from 18337b8 to 5278445 Jan 31, 2015
Ms2ger added a commit that referenced this pull request Jan 31, 2015
Remove old impl check, fix warnings; r=Ms2ger
@Ms2ger Ms2ger merged commit 105bc29 into master Jan 31, 2015
@Ms2ger Ms2ger deleted the warn-fix branch Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.