Add methods to create various matrix types.#76
Merged
pcwalton merged 1 commit intoservo:masterfrom May 28, 2015
glennw:matrix-methods
Merged
Add methods to create various matrix types.#76pcwalton merged 1 commit intoservo:masterfrom glennw:matrix-methods
pcwalton merged 1 commit intoservo:masterfrom
glennw:matrix-methods
Conversation
Member
Author
|
r? @pcwalton |
src/matrix.rs
Outdated
Contributor
There was a problem hiding this comment.
I wonder if we should make a trait that encompasses all of these to avoid repeating ourselves so much…
Member
Author
There was a problem hiding this comment.
Good idea. I intend to do a general cleanup / refactor of this matrix class as a follow up - to make method names and the API consistent.
Member
Author
|
@pcwalton Updated to address those comments. |
pcwalton
added a commit
that referenced
this pull request
May 28, 2015
Add methods to create various matrix types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.