Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upApply skew transformation for alpha and beta angles. #77
Conversation
This patch is to fix #6237 in servo.
| Matrix4(_1.clone(), sx, _0.clone(), _0.clone(), | ||
| sy, _1.clone(), _0.clone(), _0.clone(), | ||
| Matrix4(_1.clone(), beta.tan(), _0.clone(), _0.clone(), | ||
| alpha.tan(), _1.clone(), _0.clone(), _0.clone(), |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Jinwoo-Song
Jun 3, 2015
Author
Contributor
The matrix values are switched symmetrically compared to spec. You can refer other transform functions such as create_translation().
|
Review status: all files reviewed, 1 unresolved discussion, all commit checks successful.
src/matrix.rs, line 174 [r1] (raw file): Comments from the review on Reviewable.io |
|
|
|
@Jinwoo-Song It needs a rebase. |
|
@Jinwoo-Song Or are you planning to continue work on this? |
|
Rebased in #100. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Jinwoo-Song commentedJun 3, 2015
This patch is to fix servo/servo#6237.
r? @pcwalton @glennw @nox
cc @yichoi