Various improvements, clean up warnings, restructure constructors #81

frewsxcv · 2015-06-09T04:53:28Z

No more warnings
Make most constructors into associated funtions
A couple other cleanup things

Basically, just check each individual commit. If not all of this is wanted, feel free to cherry pick.

Manishearth · 2015-06-09T05:16:27Z

src/matrix.rs

@@ -35,6 +21,54 @@ pub struct Matrix4<T> {
    pub m41: T, pub m42: T, pub m43: T, pub m44: T,
 }

+impl<T: Float> Matrix4<T> {
+    pub fn new(


Note: We discussed removing the generics from this entirely in the meeting. But we can merge this independently.

cc @glennw

Ms2ger · 2015-06-09T09:29:41Z

Have you updated Servo already?

frewsxcv · 2015-06-09T13:10:39Z

Have you updated Servo already?

@Ms2ger Not yet. I wasn't sure if the changes in the pull requests were desired. If they are, I can make the changes to servo

bors-servo · 2015-06-10T21:03:15Z

☔ The latest upstream changes (presumably #82) made this pull request unmergeable. Please resolve the merge conflicts.

frewsxcv · 2015-06-10T23:20:30Z

From IRC:

2:34 PM <•gw> frewsxcv: sorry to get my merge in first :P personally I'm fine with that PR, it makes sense to me - but I'm not sure if there's a style guideline for using ::new() vs. what is there now - anyone?
...
3:00 PM <•jack> frewsxcv, gw: I think new is preferred. The convention (from long, long ago) was to use the type name as a function, but that is not longer the case.
...
3:02 PM <•gw> jack: thanks. frewsxcv: if you want to rebase that I'll r+ it


        Migrate Matrix4 functions into associated functions

geom::matrix::ortho -> geom::Matrix4::ortho geom::matrix::identity -> geom::Matrix4::identity


        Migrate Matrix4 primary constructor to associated fn


        Migrate Point2D primary constructor to associated fn


        Remove unused imports


        Migrate Size2D primary constructor to associated fn


        Remove unnecessary type suffixes on ints in tests


        Migrate Rect primary constructor to associated fn

frewsxcv · 2015-06-11T00:52:05Z

@glennw Rebased

glennw · 2015-06-11T00:56:58Z

@frewsxcv Looks good to me. Want to get the PRs done for rust-layers and servo (any anything else that needs it), and then we can merge them all at around the same time?


        rust-geom API changes

servo/euclid#81


        rust-geom API changes

servo/euclid#81

mbrubeck · 2015-06-11T03:31:52Z

Maybe this should bump the version in Cargo.toml to 0.2.0? That might make it easier to track which downstream packages have been updated.


        Bump version because of breaking changes

servo#81 (comment)


        Migrate TypedSize2D primary constructor to associated fn


        Migrate TypedPoint2D primary constructor to associated fn


        rust-geom API changes

servo/euclid#81


        rust-geom API changes

servo/euclid#81

pcwalton · 2015-06-12T03:54:18Z

@mbrubeck Are you OK with this now? It looks fine to me.

frewsxcv · 2015-06-12T03:58:06Z

Associated PRs:

Admittedly this does add a few characters per initialization, but I don't think it harms readability and ends up being more idiomatic.

mbrubeck · 2015-06-12T16:31:13Z

Yes, LGTM.


        Merge pull request #81 from frewsxcv/improvements

Various improvements, clean up warnings, restructure constructors


        rust-geom API changes

servo/euclid#81


        rust-geom API changes

servo/euclid#81


        Auto merge of #178 - frewsxcv:geom-api-changes, r=Ms2ger

servo/euclid#81


        rust-geom API changes

servo/euclid#81


        rust-geom API changes

servo/euclid#81


        rust-geom API changes

servo/euclid#81


        Auto merge of #6349 - frewsxcv:geom-api-changes, r=pcwalton

Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6349)


        rust-geom API changes

servo/euclid#81


        rust-geom API changes

servo/euclid#81


        Auto merge of #6349 - frewsxcv:geom-api-changes, r=pcwalton

Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6349)


        rust-geom API changes

servo/euclid#81


        Auto merge of #6349 - frewsxcv:geom-api-changes, r=pcwalton

Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6349)


        rust-geom API changes

servo/euclid#81


        Auto merge of #6349 - frewsxcv:geom-api-changes, r=pcwalton

Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6349)


        servo: Merge #6349 - rust-geom API changes (from frewsxcv:geom-api-ch…

…anges); r=pcwalton Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ Source-Repo: https://github.com/servo/servo Source-Revision: cfcd8589d06935f83b903f76477ea03e4d4652d0


        servo: Merge #6349 - rust-geom API changes (from frewsxcv:geom-api-ch…

…anges); r=pcwalton Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ Source-Repo: https://github.com/servo/servo Source-Revision: cfcd8589d06935f83b903f76477ea03e4d4652d0 UltraBlame original commit: d70837d5150f00c1534f60d6ca265952259c90a3


        servo: Merge #6349 - rust-geom API changes (from frewsxcv:geom-api-ch…

…anges); r=pcwalton Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ Source-Repo: https://github.com/servo/servo Source-Revision: cfcd8589d06935f83b903f76477ea03e4d4652d0 UltraBlame original commit: d70837d5150f00c1534f60d6ca265952259c90a3


        servo: Merge #6349 - rust-geom API changes (from frewsxcv:geom-api-ch…

…anges); r=pcwalton Shouldn't be merged until these have merged: servo/euclid#81 servo/surfman#13 servo/rust-layers#178 ~~I'll also need to update the Cargo lock files once they merge~~ Source-Repo: https://github.com/servo/servo Source-Revision: cfcd8589d06935f83b903f76477ea03e4d4652d0 UltraBlame original commit: d70837d5150f00c1534f60d6ca265952259c90a3

Manishearth reviewed Jun 9, 2015
View changes

frewsxcv added 7 commits Jun 8, 2015

Migrate Matrix4 functions into associated functions

db8d8d1

geom::matrix::ortho -> geom::Matrix4::ortho geom::matrix::identity -> geom::Matrix4::identity

Migrate Matrix4 primary constructor to associated fn

65f008d

Migrate Point2D primary constructor to associated fn

90bc0ac

Remove unused imports

53f7e51

Migrate Size2D primary constructor to associated fn

ed5a723

Remove unnecessary type suffixes on ints in tests

cf0f61d

Migrate Rect primary constructor to associated fn

1c0af83

frewsxcv force-pushed the frewsxcv:improvements branch from eeb4b99 to 5838beb Jun 11, 2015

frewsxcv added a commit to frewsxcv/rust-layers that referenced this pull request Jun 11, 2015

rust-geom API changes

daee17e

servo/euclid#81

frewsxcv mentioned this pull request Jun 11, 2015

rust-geom API changes servo/rust-layers#178

Merged

frewsxcv added a commit to frewsxcv/rust-layers that referenced this pull request Jun 11, 2015

rust-geom API changes

a20cabc

servo/euclid#81

frewsxcv added a commit to frewsxcv/rust-geom that referenced this pull request Jun 11, 2015

Bump version because of breaking changes

c4d6dac

servo#81 (comment)

frewsxcv force-pushed the frewsxcv:improvements branch from c4d6dac to 27e0208 Jun 12, 2015

frewsxcv added 2 commits Jun 8, 2015

Migrate TypedSize2D primary constructor to associated fn

5d1b5dd

Migrate TypedPoint2D primary constructor to associated fn

Loading status checks…

94a3e02

frewsxcv force-pushed the frewsxcv:improvements branch from 27e0208 to 94a3e02 Jun 12, 2015

frewsxcv added a commit to frewsxcv/rust-offscreen-rendering-context that referenced this pull request Jun 12, 2015

rust-geom API changes

aba6ec5

servo/euclid#81

frewsxcv mentioned this pull request Jun 12, 2015

rust-geom API changes servo/surfman#13

Merged

frewsxcv added a commit to frewsxcv/servo that referenced this pull request Jun 12, 2015

rust-geom API changes

f48da1f

servo/euclid#81

frewsxcv mentioned this pull request Jun 12, 2015

rust-geom API changes servo/servo#6349

Merged

frewsxcv added a commit that referenced this pull request Jun 12, 2015

Merge pull request #81 from frewsxcv/improvements

Loading status checks…

16b91af

Various improvements, clean up warnings, restructure constructors

frewsxcv merged commit 16b91af into servo:master Jun 12, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

frewsxcv deleted the frewsxcv:improvements branch Jun 12, 2015

frewsxcv added a commit to frewsxcv/rust-layers that referenced this pull request Jun 12, 2015

rust-geom API changes

08bb552

servo/euclid#81

frewsxcv added a commit to frewsxcv/rust-layers that referenced this pull request Jun 12, 2015

rust-geom API changes

c341005

servo/euclid#81

bors-servo pushed a commit to servo/rust-layers that referenced this pull request Jun 12, 2015

Auto merge of #178 - frewsxcv:geom-api-changes, r=Ms2ger

Loading status checks…

e566d3f

servo/euclid#81

frewsxcv added a commit to frewsxcv/rust-offscreen-rendering-context that referenced this pull request Jun 12, 2015

rust-geom API changes

0173bd3

servo/euclid#81

frewsxcv added a commit to frewsxcv/rust-offscreen-rendering-context that referenced this pull request Jun 12, 2015

rust-geom API changes

733b88f

servo/euclid#81

frewsxcv added a commit to frewsxcv/servo that referenced this pull request Jun 12, 2015

rust-geom API changes

7afcf98

servo/euclid#81

frewsxcv added a commit to frewsxcv/servo that referenced this pull request Jun 13, 2015

rust-geom API changes

f4db2bb

servo/euclid#81

frewsxcv added a commit to frewsxcv/servo that referenced this pull request Jun 13, 2015

rust-geom API changes

d59e507

servo/euclid#81

frewsxcv added a commit to frewsxcv/servo that referenced this pull request Jun 13, 2015

rust-geom API changes

0a9e05e

servo/euclid#81

frewsxcv added a commit to frewsxcv/servo that referenced this pull request Jun 13, 2015

rust-geom API changes

5c408d2

servo/euclid#81

servo / euclid

Various improvements, clean up warnings, restructure constructors #81

Various improvements, clean up warnings, restructure constructors #81

frewsxcv commented Jun 9, 2015

This comment has been minimized.

Ms2ger commented Jun 9, 2015

frewsxcv commented Jun 9, 2015

bors-servo commented Jun 10, 2015

frewsxcv commented Jun 10, 2015

frewsxcv commented Jun 11, 2015

glennw commented Jun 11, 2015

mbrubeck commented Jun 11, 2015

pcwalton commented Jun 12, 2015

frewsxcv commented Jun 12, 2015

mbrubeck commented Jun 12, 2015

servo / euclid

Join GitHub today

Various improvements, clean up warnings, restructure constructors #81

Various improvements, clean up warnings, restructure constructors #81

Conversation

frewsxcv commented Jun 9, 2015

This comment has been minimized.

Manishearth Jun 9, 2015

Ms2ger commented Jun 9, 2015

frewsxcv commented Jun 9, 2015

bors-servo commented Jun 10, 2015

frewsxcv commented Jun 10, 2015

frewsxcv commented Jun 11, 2015

glennw commented Jun 11, 2015

mbrubeck commented Jun 11, 2015

pcwalton commented Jun 12, 2015

frewsxcv commented Jun 12, 2015

mbrubeck commented Jun 12, 2015