Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix build failure when downstream crates attempt to build font-kit on Windows #105
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Osspial commentedOct 6, 2019
•
edited
When de6fabc got merged, the dependency that loaded
winapi'ssysinfoapifeature got removed. This fails builds when attempting to buildfont-kitdownstream (i.e. if you depend ongit = "https://github.com/pcwalton/font-kit.git"throughCargo.toml), but it does not fail when you runcargo buildwithinfont-kit's folder directly.I don't know why cargo behaves that way. I assume it's a bug. Still, this fixes that behavior by making the
sysinfoapidependency explicit. For good measure, we make all the otherwinapidependency features explicit to ensure this same sort of issue doesn't happen again.