Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade freetype #144
Closed
Upgrade freetype #144
+3
−6
Conversation
|
| [target.'cfg(not(any(target_family = "windows", target_os = "macos", target_os = "ios")))'.dependencies] | ||
| freetype = "^0.4.1" | ||
|
|
||
| [target.'cfg(not(any(target_family = "windows", target_os = "macos", target_os = "ios", target_arch = "wasm32")))'.dependencies] | ||
| servo-fontconfig = "0.4" | ||
| freetype = "^0.5.1" |
Comment on lines
-57
to
+58
This comment has been minimized.
This comment has been minimized.
jdm
May 2, 2020
Member
Looks like this got messed up - we still need to depend on fontconfig, and the freetype dependency should still be conditional.
bors-servo
added a commit
that referenced
this pull request
Jun 1, 2020
Upgrade FreeType dep from 0.4.1 to 0.5.1 Hello! I also needed the change seen in #144, so I decided to open my PR. Are you open to bumping this version? In my project, I am trying to use [servo/rust-freetype](https://github.com/servo/rust-freetype) v0.5.1, but since `font-kit` currently depends on FreeType v0.4.1 I get this error during compilation: ``` error: multiple packages link to native library `freetype`, but a native library can be linked only once package `freetype-sys v0.11.0` ... which is depended on by `freetype v0.5.1` ... which is depended on by `kosmonaut v0.1.0 (/home/twilco/projects/kosmonaut)` links to native library `freetype` package `servo-freetype-sys v4.0.3` ... which is depended on by `freetype v0.4.1` ... which is depended on by `font-kit v0.7.1` ... which is depended on by `kosmonaut v0.1.0 (/home/twilco/projects/kosmonaut)` also links to native library `freetype` ``` I could probably downgrade my `rust-freetype` version, but wanted to try this first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
j4qfrost commentedMay 2, 2020
No description provided.