Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Cargo.toml #152
Merged
Update Cargo.toml #152
Conversation
I think this is a typo. It's stopping me building because I have a freetype static lib clash.
|
I believe you need to update the servo-fontconfig dependency to 0.5 as well. |
|
@bors-servo r+ |
|
|
|
|
|
Should a new release be published for this? |
Closed
|
A new release would be awesome - then I can go back to using crates.io rather than my own copy. |
|
@jdm would it make sense to yank the 8.0 release? I'm not sure how Cargo works with multiple versions of the same dependency and it sounds like that release has issues with it. |
Merged
|
I don't see a good reason to yank 0.8. |
bors-servo
added a commit
that referenced
this pull request
Jun 16, 2020
|
@derekdreery 0.9.0 is out now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
derekdreery commentedJun 8, 2020
•
edited
I think this is a typo, because it doesn't match the optional fontconfig version. It's stopping me building because I have a freetype static lib clash.