Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix DirectWrite raster bounds #18
Merged
+18
−6
Conversation
| let texture_width = texture_bounds.right - texture_bounds.left; | ||
| let texture_height = texture_bounds.bottom - texture_bounds.top; | ||
|
|
||
| Ok(Rect::new(Point2D::new(0, 0), Size2D::new(texture_width, texture_height).to_i32())) |
This comment has been minimized.
This comment has been minimized.
zacps
Dec 5, 2018
Contributor
The point should be origin.round().cast::<i32>(), which will matter when https://github.com/pcwalton/font-kit/pull/19 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fkaa commentedDec 4, 2018
Fixes #15