Resolve default fonts using fontconfig. #30

RazrFalcon · 2019-02-17T20:32:28Z

Uses the same algorithm as fc-match.

Partially fixes #25


        Resolve default fonts using fontconfig.

RazrFalcon · 2019-02-17T20:33:44Z

src/sources/fontconfig.rs


-            let font_set = FcFontList(self.fontconfig, pattern.pattern, object_set.object_set);
+            let font_set = FcFontSetCreate();


Not sure if we should free this set. All other methods do not free it too.

pcwalton · 2019-02-28T19:54:10Z

Looks good!

RazrFalcon · 2019-02-28T20:14:33Z

Thanks. But what about Win and Mac?

pcwalton · 2019-02-28T20:26:55Z

I was planning to match the behavior of Web browsers: i.e. use their defaults for serif, sans-serif, etc.

On Thu, Feb 28, 2019, 12:14 PM Evgeniy Reizner ***@***.***> wrote: Thanks. But what about Win and Mac? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <https://github.com/pcwalton/font-kit/pull/30#issuecomment-468421113>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJoyW1L4aJCGBwK6Ep_qEZ43nmNuzRlks5vSDiqgaJpZM4a_xiy> .

Resolve default fonts using fontconfig.

51f9b7d

RazrFalcon reviewed Feb 17, 2019

View changes

pcwalton merged commit e8ca5b2 into servo:master Feb 28, 2019

servo / font-kit


		let font_set = FcFontList(self.fontconfig, pattern.pattern, object_set.object_set);
		let font_set = FcFontSetCreate();