Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck results in Loader::glyph_for_char. #49
Merged
Conversation
Previously, `glyph_for_char` in CoreText and FreeType loaders were always returned `Some`, instead of checking results.
|
Looks like it doesn't work on macOS. |
|
As you can see, half of the tests are failed on macos. |
|
I've fixed the current bug, sort of, but it looks like this is even more complex: https://github.com/google/skia/blob/503414581a9537b9d8c0b9346104798e2205627b/src/ports/SkFontHost_mac.cpp#L2360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
RazrFalcon commentedMay 15, 2019
•
edited
Previously,
glyph_for_charin CoreText and FreeType loaders were alwaysreturned
Some, instead of checking results.Closes #38