Skip to content

/ font-kit

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip CoreGraphics origin in the y axis (issue #43) #51

Merged
merged 1 commit into from May 23, 2019
Merged

Flip CoreGraphics origin in the y axis (issue #43) #51

merged 1 commit into from May 23, 2019

Conversation

@futurepaul
Copy link
Contributor

futurepaul commented May 16, 2019

I believe this fixes #43. I've tested this with Raqote and ran font-kit's tests. It appears to work correctly with this subtraction.
@futurepaul
flip coregraphics origin in the y axis
94fb9a7
@futurepaul
Copy link
Contributor Author

futurepaul commented May 16, 2019

Here's how webrender handles this, from what I can tell: https://github.com/servo/webrender/blob/036c63ab862b4581ff44fdd5381acd61c53f7a33/webrender/src/platform/macos/font.rs#L642
@jrmuizel
Copy link
Collaborator

jrmuizel commented May 17, 2019

This looks good to me.
@pcwalton pcwalton merged commit 8b7105d into servo:master May 23, 2019
@pcwalton
Copy link
Collaborator

pcwalton commented May 23, 2019

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Canvas origin is flipped on macOS
3 participants
@futurepaul @jrmuizel @pcwalton
You can’t perform that action at this time.