Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExport types and not modules. #70
Closed
Conversation
|
I deliberately don't like doing this in crates that I maintain, because the compiler is not very good at saying where you should import a type from in error messages. Also, when I read library code as a user of the library, I like to be able to look at the "use" directives to see where the public types live, without having to search for "pub use". I find that a lot of Rust crates overuse "pub use" and it makes them really confusing, and I don't want to make it worse. |
|
I see. That was just a proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
RazrFalcon commentedMay 28, 2019
This is mainly a stylistic change, since I don't think that we need a complex modules structure for like 20 types. And this more Rust-like, imo.