Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProperly support the offset in dwrite and freetype loaders. #75
Conversation
This also moves the row increments below the tests so that we use the same row for the next part of the shape.
This change makes the positioning of in the canvas consistent between the loaders on all platforms. It adopts the convention of having the origin at the top left with +y going down. Glyphs with their baseline at the specified offset. This follows the convention of cairo and HTML canvas. The version is bumped because of this behaviour change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jrmuizel commentedJun 7, 2019
This change makes the positioning of in the canvas consistent between the
loaders on all platforms. It adopts the convention of having the origin at the
top left with +y going down. Glyphs with their baseline at the specified
offset. This follows the convention of cairo and HTML canvas.
The version is bumped because of this behaviour change.