Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a FontTransform to allow arbitrary transformations on glyphs. #76
Conversation
|
What do you think about replacing size with an affine transform instead? |
|
Err, I mean a 2x2 transform. |
|
Also I'm confused as to why font size needs to be different from scale… |
|
I'm not certain why, but all of the underlying system apis keep font size separate from the transform. I think it is probably wisest to just follow this convention. |
|
Yeah, OK. I agree with wanting to follow the convention. @raphlinus Maybe you can shed some light on this? |
|
This looks good when rebased, FWIW. |
|
Rebased. The test failure seems to be an intermittent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jrmuizel commentedJun 7, 2019
Fixes #34