Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate euclid. #87
Merged
Update euclid. #87
Conversation
|
I've tried to do this yesterday, but |
|
@RazrFalcon yeah, it was updated today. |
|
I guess you can also review this @RazrFalcon (if it looks sane to you) |
|
Yep, I will merge this as soon as CI will be fixed. |
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "font-kit" | |||
| version = "0.3.1" | |||
| version = "0.4.0" | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Fixed the formatting that was making travis fail and a test too. |
|
And pushed the version bump as a separate commit. |
|
I spent a bit more time and fixed the Windows build. |
jrmuizel
referenced
this pull request
in jrmuizel/raqote
Jul 23, 2019
This won't build until https://github.com/pcwalton/font-kit/pull/87 is published, but I expect it to be merged real soon (tm), and this passes tests locally (with patches applied). I need this to update euclid in Servo so as to sync style system changes in Gecko and Servo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedJul 22, 2019
No description provided.